test: added test cases for statefulset update, pdb, hpa, ingress & co… #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdheipSingh
approved these changes
May 9, 2023
AdheipSingh
reviewed
May 9, 2023
Comment on lines
+198
to
+217
| for _, componentName := range druidComponents { | ||
| componentName := componentName | ||
| It(fmt.Sprintf("Test kubernetes service for %s", componentName), func() { | ||
| createdService := &v1.Service{} | ||
| serviceName := fmt.Sprintf("druid-%s-%s", druidCR.Name, componentName) | ||
| serviceNamespacedName := types.NamespacedName{Name: serviceName, Namespace: druidCR.Namespace} | ||
|
|
||
| // Checking the kubernetes service Type | ||
| By(fmt.Sprintf("By checking kubernetes service type %s ", serviceName)) | ||
| Eventually(func() bool { | ||
| err := k8sClient.Get(context.TODO(), serviceNamespacedName, createdService) | ||
| return err == nil | ||
| }, timeout, interval).Should(BeTrue()) | ||
| Expect(createdService.Spec.Type).To(Equal(druidCR.Spec.Services[0].Spec.Type)) | ||
| // Kubernetes service check for targetport and port | ||
| By(fmt.Sprintf("By checking kubernetes service port for %s ", serviceName)) | ||
| Expect(createdService.Spec.Ports[0].Port).To(Equal(druidCR.Spec.Nodes[componentName].DruidPort)) | ||
| Expect(createdService.Spec.Ports[0].TargetPort.IntVal).To(Equal(druidCR.Spec.Nodes[componentName].DruidPort)) | ||
| }) | ||
| } |
There was a problem hiding this comment.
FYI: I had one more test in mind to assert the annotations in. a service. To enable cloud loadbalancers, druid CR nodespec.service supports adding annotations, those scenarios can also be asserted.
We can take that in a separate PR also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #42
Description
This PR includes additional test cases to check for :-
It also includes update for ingress in druid-smoke-test-cluster.yaml file.
This PR has:
Key changed/added files in this PR
controllers/druid/druid_controller_test.gocontrollers/druid/testdata/druid-smoke-test-cluster.yaml