Skip to content

removing excel_can_ac format key to address migration issue [sc-180121]#13

Merged
liamlynch-data merged 2 commits into
masterfrom
bug/dss12-sc-180121-plugin-migration-update-issue-existing-recipes
Apr 26, 2024
Merged

removing excel_can_ac format key to address migration issue [sc-180121]#13
liamlynch-data merged 2 commits into
masterfrom
bug/dss12-sc-180121-plugin-migration-update-issue-existing-recipes

Conversation

@liamlynch-data

Copy link
Copy Markdown
Contributor

No description provided.

@liamlynch-data liamlynch-data marked this pull request as ready for review April 19, 2024 15:08
@Sallsamba Sallsamba requested review from Sallsamba and removed request for MayeulRousselet April 25, 2024 13:57

@Sallsamba Sallsamba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MayeulRousselet MayeulRousselet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin version number should be also updated in plugin.json

@liamlynch-data

Copy link
Copy Markdown
Contributor Author

The plugin version number should be also updated in plugin.json

@MayeulRousselet the plugin version shouldn't change with this PR I think, it should stay on 1.0.1
Master is at 1.0.1 - which we have not released yet - and I added the changes we did here into the release notes of 1.0.1 (in addition to Arnaud's html conditional formating support). So hopefully it's ok as is.

@liamlynch-data liamlynch-data merged commit a188a26 into master Apr 26, 2024
@liamlynch-data liamlynch-data deleted the bug/dss12-sc-180121-plugin-migration-update-issue-existing-recipes branch April 26, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants