Add OAuth2 to GoogleDrive connector #2
Conversation
…extarea for credentials in presets
There was a problem hiding this comment.
I have quickly looked at the code and had minor comments and suggestions on the code itself.
Otherwise I tried the plugin with OAuth on my local DSS 8.0. It worked correctly for the Auth part and I could read Google Drive datasets and folders. But I encountered some issues, especially for write operations:
- The dataset/folder creation experience can be very slow for big Google Drive folders. Could we add a % loader? Or avoid downloading/listing everything?
- Why do we forbid "Placing a managed folder at the root of a connection is not permitted" for folders. To me, reading a given Google Drive folder is what most users want to do. Instead, the folder creation process on Google Drive starts at the default path of
/${projectKey}/${odbId}which gives you a "Selected path does not exist" message. - I was not able to use the "merge folder" recipe to read from one Google Drive folder and write to another. See job diag: https://dl.dataiku.com/file/LRxY4gEMYnk1wFU5/L11ySYkZb8simp7c/dss-job-diag-TESTGOOGLEDRIVEPLUGINOAUTH-Build_gdfolder_2020-09-17T17-23-05.277_%20(1).zip
- Syncing from one Google Drive dataset to another one failed. See job diag attached: https://dl.dataiku.com/file/LaftzuZEGPZw1f7W/19vcxzw67jg6Ocmj/dss-job-diag-TESTGOOGLEDRIVEPLUGINOAUTH-Build_Google_Drive_3_2020-09-17T17-21-42.854_.zip - Note that I am using python 3.5.
python-tests/test_metadata.py
Outdated
| import os, sys | ||
|
|
||
| ## Add stuff to the path to enable exec outside of DSS | ||
| plugin_root = os.path.dirname(os.path.dirname(os.path.realpath(__file__))) |
There was a problem hiding this comment.
No need for that, the template Makefile: https://github.com/dataiku/dss-plugin-template/blob/master/Makefile takes care of it.
|
Hi @alexbourret, |
|
@alexcombessie I just implemented this proposed solution and it seems to fix the error messages... |
No description provided.