Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customizing topic names via a convention. #1843

Closed
wants to merge 1 commit into from
Closed

Add support for customizing topic names via a convention. #1843

wants to merge 1 commit into from

Conversation

jplaisted
Copy link
Contributor

Requested by a few people in OS.

Companies probably need to pick _ or . as a delimiter and we hard coded _

TODO to finish the implmentation for v5. For right now v5 is LI only and unfinished. Getting this in for v4 so it is useful to other companies now.

TODO BEFORE SUBMIT - make configurable via spring
TODO BEFORE SUBMIT - decide if this needs to be an internal RB first
TODO BEFORE SUBMIT - see where else we can use this (jobs, where else?)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Requested by a few people in OS.

Companies probably need to pick _ or . as a delimiter and we hard coded _

TODO to finish the implmentation for v5. For right now v5 is LI only and unfinished. Getting this in for v4 so it is useful to other companies now.

TODO BEFORE SUBMIT - make configurable via spring
TODO BEFORE SUBMIT - decide if this needs to be an internal RB first
TODO BEFORE SUBMIT - see where else we can use this (jobs, where else?)
@jplaisted
Copy link
Contributor Author

I probably won't pull this in, I'll have to submit internally I think*, just using it for discussion.

*we don't have a great pull mechanism right now, but I'm working on fixing that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant