Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes): Improve the security of the kubernetes/helm charts #1782

Merged
merged 12 commits into from
Aug 20, 2020
Merged

feat(kubernetes): Improve the security of the kubernetes/helm charts #1782

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
49c2dad
1747 | remove obsolete yaml files
shakti-garg Jul 27, 2020
0e2ce99
1747 | remove configmap and its hardcoded references
shakti-garg Aug 3, 2020
2c15a8c
1747 | add missing input parameter of neo4j.host
shakti-garg Aug 3, 2020
0718d3b
1747 | remove obsolete secrets and parameterize the rest
shakti-garg Aug 3, 2020
b22ceed
1747 | auto-generate gms secret
shakti-garg Aug 3, 2020
1935dd4
1747 | remove fullName overrides
shakti-garg Aug 3, 2020
3893c10
1747 | fix parameters in subchart's values.yaml
shakti-garg Aug 3, 2020
15b73c6
1747 | remove hardcoding from parameters for gms host and port
shakti-garg Aug 3, 2020
8d4e127
1747 | upgrade chart version
shakti-garg Aug 6, 2020
fbfe213
1747 | update helm docs
shakti-garg Aug 6, 2020
e395b4b
1747 | add extraEnv, extraVolume and extraMounts
shakti-garg Aug 8, 2020
4ed37b1
1747 | Alters pull policy of images to 'always' for ldh
shakti-garg Aug 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
1747 | remove hardcoding from parameters for gms host and port
  • Loading branch information
@shakti-garg
shakti-garg committed Aug 8, 2020
commit 15b73c6be47367542ac15f9f3f4a18aad940332a
2 changes: 1 addition & 1 deletion contrib/kubernetes/datahub/charts/datahub-frontend/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
port: http
env:
- name: DATAHUB_GMS_HOST
value: "{{ .Values.global.datahub.gms.host }}"
value: {{ printf "%s-%s" .Release.Name "datahub-gms" }}
- name: DATAHUB_GMS_PORT
value: "{{ .Values.global.datahub.gms.port }}"
- name: DATAHUB_SECRET
Expand Down
1 change: 0 additions & 1 deletion contrib/kubernetes/datahub/charts/datahub-frontend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,5 @@ datahub:
global:
datahub:
gms:
host: "datahub-gms-deployment"
port: "8080"
appVersion: "1.0"
4 changes: 2 additions & 2 deletions contrib/kubernetes/datahub/charts/datahub-gms/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
apiVersion: v1
kind: Service
metadata:
name: {{ include "datahub-gms.fullname" . }}
name: {{ printf "%s-%s" .Release.Name "datahub-gms" }}
labels:
{{- include "datahub-gms.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
- port: {{ .Values.global.datahub.gms.port }}
targetPort: http
protocol: TCP
name: http
Expand Down
2 changes: 0 additions & 2 deletions contrib/kubernetes/datahub/charts/datahub-gms/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ securityContext: {}

service:
type: LoadBalancer #ClusterIP
port: 8080

ingress:
enabled: false
Expand Down Expand Up @@ -101,7 +100,6 @@ global:

datahub:
gms:
host: "datahub-gms-service"
port: "8080"
appVersion: "1.0"

Expand Down
2 changes: 1 addition & 1 deletion contrib/kubernetes/datahub/charts/datahub-mce-consumer/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
- name: KAFKA_SCHEMAREGISTRY_URL
value: "{{ .Values.global.kafka.schemaregistry.url }}"
- name: GMS_HOST
value: "{{ .Values.global.datahub.gms.host }}"
value: {{ printf "%s-%s" .Release.Name "datahub-gms" }}
- name: GMS_PORT
value: "{{ .Values.global.datahub.gms.port }}"
resources:
Expand Down
1 change: 0 additions & 1 deletion contrib/kubernetes/datahub/charts/datahub-mce-consumer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ global:

datahub:
gms:
host: "datahub-gms-deployment"
port: "8080"

hostAliases:
Expand Down
1 change: 0 additions & 1 deletion contrib/kubernetes/datahub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ global:

datahub:
gms:
host: "datahub-gms-deployment"
port: "8080"
appVersion: "1.0"

Expand Down