fix(gms): forward ssl.keystore.type/truststore.type to schema registr…#16997
Open
manuschillerdev wants to merge 2 commits intodatahub-project:masterfrom
Open
fix(gms): forward ssl.keystore.type/truststore.type to schema registr…#16997manuschillerdev wants to merge 2 commits intodatahub-project:masterfrom
manuschillerdev wants to merge 2 commits intodatahub-project:masterfrom
Conversation
Contributor
|
Linear: PFP-3336 Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ssl.keystore.type/ssl.truststore.typeto the@Valueallowlist inKafkaSchemaRegistryFactory. Without this, the factory silently drops those two keys from the schema-registry props map, and the consumer/producer factories thenputAll()the factory's output after Spring Boot's auto-binding, so anySPRING_KAFKA_PROPERTIES_SCHEMA_REGISTRY_SSL_KEYSTORE_TYPE=PEMthe operator setgets overwritten. This blocks PEM TLS for the Confluent schema-registry REST hop from GMS/MAE/MCE consumers, even though the client itself fully supports PEM via its own
SslFactory(https://github.com/confluentinc/schema-registry/blob/v8.0.0/client/src/main/java/io/confluent/kafka/schemaregistry/client/security/SslFactory.java).The two new fields default to empty string and are only forwarded to the props map when actually set — existing JKS deployments that rely on the client's default
typebehavior are unaffected.This is one of the code fixes from RFC datahub-project/datahub#16975 (PEM-first TLS for DataHub outbound connections). Adjacent to datahub-project/datahub#14354 (MAE/MCE consumers can't reach Schema Registry with TLS) and acryldata/datahub-helm#601 (chart has no unified SSL story)