feat(models): add searchTier annotations to glossary and document definitions#16995
Open
loustler wants to merge 1 commit intodatahub-project:masterfrom
Open
feat(models): add searchTier annotations to glossary and document definitions#16995loustler wants to merge 1 commit intodatahub-project:masterfrom
loustler wants to merge 1 commit intodatahub-project:masterfrom
Conversation
…initions Assign searchTier 2 to GlossaryNodeInfo.definition, GlossaryTermInfo.definition, and DocumentContents.text so these fields participate in V3 tiered search scoring. Tier 2 is consistent with other description/definition fields across the model.
github-actions
bot
added
the
community-contribution
Contributor
|
Linear: PFP-3335 Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned. |
maggiehays
added
the
needs-review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
david-leifker
added
the
merge-pending-ci
Contributor
|
Your PR has been assigned to @david-leifker (david.leifker) for review (PFP-3335). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
definitionfield onGlossaryNodeInfoandGlossaryTermInfo, and thetextfield onDocumentContents, are annotated with@Searchablebut lack asearchTierassignment. In the V3 tiered search architecture, fields without asearchTierare not copied into the_search.tier_Nconsolidated fields and therefore don't participate in tiered relevance scoring.This PR assigns
searchTier: 2(description/definition tier) to these fields, consistent with similar fields across the model:DatasetProperties.name,ChartInfo.title,GlossaryTermInfo.nameDatasetProperties.description,ChartInfo.descriptionDatasetProperties.qualifiedNameChanges
metadata-models/.../GlossaryNodeInfo.pdl"fieldType": "TEXT", "searchTier": 2todefinitionmetadata-models/.../GlossaryTermInfo.pdl"fieldType": "TEXT", "searchTier": 2todefinitionmetadata-models/.../DocumentContents.pdl"searchTier": 2totext(already hadfieldType: TEXT)Notes
GlossaryNodeInfo.definitionandGlossaryTermInfo.definitionpreviously had@Searchable = {}(empty annotation). This explicitly setsfieldType: TEXTwhich was previously the implicit default. No behavioral change for V2 search.copy_todirectives are generated at index creation time based onsearchTiervalues).Checklist