Skip to content

feat(ui): add global styles and support for dark mode #16965

Open
purnimagarg1 wants to merge 5 commits intomasterfrom
pg--cat-1770-dark-mode-support
Open

feat(ui): add global styles and support for dark mode #16965
purnimagarg1 wants to merge 5 commits intomasterfrom
pg--cat-1770-dark-mode-support

Conversation

@purnimagarg1
Copy link
Copy Markdown
Collaborator

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Linear: CAT-1772

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Bundle Report

Changes will increase total bundle size by 21.19kB (0.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.75MB 21.19kB (0.09%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 21.19kB 12.5MB 0.17%

Files in assets/index-*.js:

  • ./src/app/useSetAppTheme.tsx → Total Size: 1.82kB

  • ./src/CustomThemeProvider.tsx → Total Size: 676 bytes

  • ./src/app/theme/useIsDarkMode.ts → Total Size: 1.13kB

  • ./src/app/theme/GlobalThemeStyles.tsx → Total Size: 19.41kB

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous bot commented Apr 9, 2026

🔴 Meticulous spotted visual differences in 777 of 1446 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 81f776d Merge branch 'master' into pg--cat-1770-dark-mode-support. This comment will update as new commits are pushed.

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants