Skip to content

Conversation

sakethvarma397
Copy link
Contributor

Noticed that a few entity types fetch domain and dataproduct information to render the Search Result and Preview. These are technically not used by the underlying DefaultPreviewCard .
Leaving those unused props as is on those components, but dropping domain and dataProduct from Search Result related graph objects. For few customers, this reduced the response size from 40kb -> 30kb.

These fragments are not used by any other feature ( getEntities end point uses it, but it's used to render entities in dropdown etc where we wouldn't need this info anyway), so should be a safe fix.

Copy link

alwaysmeticulous bot commented Oct 17, 2025

🔴 Meticulous spotted visual differences in 51 of 993 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit ef64efb. This comment will update as new commits are pushed.

Copy link

codecov bot commented Oct 17, 2025

Bundle Report

Changes will decrease total bundle size by 890 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.57MB -890 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -890 bytes 18.91MB -0.0%

Files in assets/index-*.js:

  • ./src/app/entityV2/dataFlow/DataFlowEntity.tsx → Total Size: 5.75kB

  • ./src/app/entityV2/dataset/DatasetEntity.tsx → Total Size: 13.2kB

  • ./src/app/entityV2/dashboard/DashboardEntity.tsx → Total Size: 10.32kB

  • ./src/app/entityV2/dataJob/DataJobEntity.tsx → Total Size: 7.68kB

  • ./src/app/entityV2/chart/ChartEntity.tsx → Total Size: 9.08kB

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 17, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Oct 18, 2025
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants