-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(file-upload): implement selecting and uploading file via button on the editor toolbar #15036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cc--ch-824-ch-825-file-upload-extension
Are you sure you want to change the base?
feat(file-upload): implement selecting and uploading file via button on the editor toolbar #15036
Conversation
🔴 Meticulous spotted visual differences in 12 of 993 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit a64c12a. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 5.6kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
24703b5
to
1e6ada8
Compare
Linear ticket:
https://linear.app/acryl-data/issue/CH-831/implement-ui-for-prompting-user-to-select-file-from-their-system
Description:
This adds a new button in rich text editor toolbar to upload file and handles file upload using the existing FileDragDropExtension
Screenshot:
Video:
Screen.Recording.2025-10-17.at.4.21.47.PM.mov