Skip to content

Conversation

purnimagarg1
Copy link
Collaborator

Linear ticket:
https://linear.app/acryl-data/issue/CH-831/implement-ui-for-prompting-user-to-select-file-from-their-system

Description:

This adds a new button in rich text editor toolbar to upload file and handles file upload using the existing FileDragDropExtension

Screenshot:

image

Video:

Screen.Recording.2025-10-17.at.4.21.47.PM.mov

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 17, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 17, 2025
Copy link

alwaysmeticulous bot commented Oct 17, 2025

🔴 Meticulous spotted visual differences in 12 of 993 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit a64c12a. This comment will update as new commits are pushed.

Copy link

codecov bot commented Oct 17, 2025

Bundle Report

Changes will increase total bundle size by 5.6kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.6MB 5.6kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 5.6kB 18.94MB 0.03%

Files in assets/index-*.js:

  • ./src/alchemy-components/components/Editor/toolbar/FileUploadButton.tsx → Total Size: 2.91kB

  • ./src/alchemy-components/components/Editor/toolbar/Toolbar.tsx → Total Size: 3.74kB

  • ./src/alchemy-components/components/Editor/extensions/fileDragDrop/FileDragDropExtension.tsx → Total Size: 7.25kB

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@purnimagarg1 purnimagarg1 changed the title implement selecting and uploading file via button on the editor toolbar feat(file-upload): implement selecting and uploading file via button on the editor toolbar Oct 17, 2025
@chriscollins3456 chriscollins3456 force-pushed the cc--ch-824-ch-825-file-upload-extension branch 2 times, most recently from 24703b5 to 1e6ada8 Compare October 18, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants