feat(ui) Add new file upload to S3 extension in the UI #15004

chriscollins3456 · 2025-10-14T16:50:40Z

This PR builds a new extension that allows us to drag and drop files into our rich text Editor component and upload them to S3, completing the desired flow of requesting a presigned URL, uploading to S3, then rendering a classic markdown link/image with a reference to our own file service REST API (what this PR is built on top of).

Right now this is only enabled on the new summary tab, but we have another PR coming out where we can support this for all entity documentation and extend support elsewhere as well.

Screen.Recording.2025-10-14.at.12.49.30.PM.mov

alwaysmeticulous · 2025-10-14T16:56:17Z

🔴 Meticulous spotted visual differences in 18 of 1093 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

_{Last updated for commit 2feca70. This comment will update as new commits are pushed.}

codecov · 2025-10-14T16:58:51Z

Bundle Report

Changes will increase total bundle size by 8.11kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	28.58MB	8.11kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	8.11kB	18.92MB	0.04%

Files in assets/index-*.js:

./src/alchemy-components/components/Editor/extensions/fileDragDrop/fileUtils.ts → Total Size: 3.42kB
./src/alchemy-components/components/Editor/extensions/fileDragDrop/FileNodeView.tsx → Total Size: 1.66kB
./src/alchemy-components/components/Editor/extensions/fileDragDrop/FileDragDropExtension.tsx → Total Size: 7.25kB
./src/app/entityV2/summary/documentation/EditDescriptionModal.tsx → Total Size: 1.7kB
./src/app/shared/Loading.tsx → Total Size: 852 bytes
./src/alchemy-components/components/Editor/Editor.tsx → Total Size: 2.85kB
./src/app/shared/hooks/useFileUpload.ts → Total Size: 1.13kB
./src/alchemy-components/components/Editor/extensions/htmlToMarkdown.tsx → Total Size: 4.57kB
./src/alchemy-components/components/Editor/extensions/markdownToHtml.tsx → Total Size: 592 bytes

codecov · 2025-10-14T17:11:06Z

Codecov Report

❌ Patch coverage is 98.35165% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...components/Editor/extensions/fileDragDrop/index.ts	0.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

v-tarasevich-blitz-brain · 2025-10-15T07:56:50Z

datahub-web-react/src/app/entityV2/summary/documentation/AboutSection.tsx

        removeEditingParam();
    };

+    const { uploadFile } = useFileUpload({ scenario: UploadDownloadScenario.AssetDocumentation, assetUrn });


Somewhere we have to add checking of our feature flag to enable/disable uploading

added this to useFileUpload

v-tarasevich-blitz-brain · 2025-10-15T08:02:56Z

datahub-web-react/src/alchemy-components/components/Editor/extensions/fileDragDrop/fileUtils.ts

+        url.includes('amazonaws.com') || // Other AWS storage
+        url.includes('storage.googleapis.com') || // Google Cloud Storage
+        url.includes('blob.core.windows.net') || // Azure Blob Storage
+        url.match(/\.(pdf|doc|docx|xls|xlsx|ppt|pptx|txt|jpg|jpeg|png|gif|webp|mp4|mp3|zip|rar)$/i) !== null // File extensions


can we generate the pattern from EXTENSION_TO_FILE_TYPE to keep them in sync?

yes good call, let me try and do that

actually i opted to simplify this function since we only really need the check for our own urls which begin with openapi/v1/files

github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 14, 2025

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 14, 2025

github-actions bot deployed to datahub-project-web-react (Preview) October 14, 2025 16:55 View deployment

v-tarasevich-blitz-brain reviewed Oct 15, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 15, 2025

github-actions bot deployed to datahub-project-web-react (Preview) October 15, 2025 15:48 View deployment

datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Oct 15, 2025

vercel bot deployed to Preview October 15, 2025 16:18 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) October 15, 2025 16:31 View deployment

vercel bot deployed to Preview October 15, 2025 16:52 View deployment

chriscollins3456 force-pushed the cc--ch-823-download-rest-endpoint branch 2 times, most recently from f06d841 to 610c0df Compare October 17, 2025 21:50

chriscollins3456 force-pushed the cc--ch-824-ch-825-file-upload-extension branch from 9367e7d to 6d78ec4 Compare October 17, 2025 23:01

github-actions bot deployed to datahub-project-web-react (Preview) October 17, 2025 23:07 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) October 17, 2025 23:19 View deployment

vercel bot deployed to Preview October 17, 2025 23:35 View deployment

chriscollins3456 added 5 commits October 17, 2025 22:37

feat(ui) Add new file upload to S3 extension in the UI

9297253

fix bug with files with spaces in them

ff30249

hide extension without uploadFile

cc7ad4e

undo hiding of file extension

8dca11a

consider feature flag, update endpoint, update tests

1e6ada8

chriscollins3456 force-pushed the cc--ch-824-ch-825-file-upload-extension branch from 24703b5 to 1e6ada8 Compare October 18, 2025 02:38

github-actions bot deployed to datahub-project-web-react (Preview) October 18, 2025 02:43 View deployment

update tests to useFileUpload after recent changes

2feca70

chriscollins3456 changed the base branch from cc--ch-823-download-rest-endpoint to master October 18, 2025 02:44

github-actions bot deployed to datahub-project-web-react (Preview) October 18, 2025 02:49 View deployment

vercel bot deployed to Preview October 18, 2025 03:11 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ui) Add new file upload to S3 extension in the UI #15004

feat(ui) Add new file upload to S3 extension in the UI #15004

Uh oh!

chriscollins3456 commented Oct 14, 2025

Uh oh!

alwaysmeticulous bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 14, 2025 •

edited

Loading

Assets Changed:

Uh oh!

codecov bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

v-tarasevich-blitz-brain Oct 15, 2025

Uh oh!

chriscollins3456 Oct 17, 2025

Uh oh!

v-tarasevich-blitz-brain Oct 15, 2025

Uh oh!

chriscollins3456 Oct 17, 2025

Uh oh!

chriscollins3456 Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(ui) Add new file upload to S3 extension in the UI #15004

Are you sure you want to change the base?

feat(ui) Add new file upload to S3 extension in the UI #15004

Uh oh!

Conversation

chriscollins3456 commented Oct 14, 2025

Uh oh!

alwaysmeticulous bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

v-tarasevich-blitz-brain Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alwaysmeticulous bot commented Oct 14, 2025 •

edited

Loading

codecov bot commented Oct 14, 2025 •

edited

Loading

codecov bot commented Oct 14, 2025 •

edited

Loading