Skip to content

bug(security): removed View Analytics from all users and blocked acce… #14453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

benjiaming
Copy link
Contributor

@benjiaming benjiaming commented Aug 14, 2025

Summary: security fix to block exposed urls

Addresses:

Note:

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Aug 14, 2025
Copy link

alwaysmeticulous bot commented Aug 14, 2025

✅ Meticulous spotted visual differences in 72 of 1479 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 5a781ca. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Bundle Report

Changes will increase total bundle size by 1.78kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.48MB 1.78kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 1.78kB 18.83MB 0.01%

Files in assets/index-*.js:

  • ./src/app/settingsV2/SettingsPage.tsx → Total Size: 8.14kB

  • ./src/app/settingsV2/settingsPaths.tsx → Total Size: 3.0kB

  • ./src/app/SearchRoutes.tsx → Total Size: 5.28kB

  • ./src/app/shared/NoPageFound.tsx → Total Size: 1.75kB

  • ./src/app/settings/SettingsPage.tsx → Total Size: 8.6kB

Copy link

codecov bot commented Aug 14, 2025

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
156 11 145 0
View the top 3 failed test(s) by shortest run time
manage ownership cypress/e2e/ownership/manage_ownership.js::cypress/e2e/ownership/manage_ownership.js
Stack Traces | 11.4s run time
2025-08-16T03:32:41.097Z
Timed out retrying after 10000ms: Expected to find content: 'Manage Ownership' but never did.
manage ownership cypress/e2e/ownershipV2/v2_manage_ownership.js::cypress/e2e/ownershipV2/v2_manage_ownership.js
Stack Traces | 11.5s run time
2025-08-16T03:29:22.903Z
Timed out retrying after 10000ms: Expected to find content: 'Manage Ownership' but never did.
add_user cypress/e2e/mutations/add_users.js::cypress/e2e/mutations/add_users.js
Stack Traces | 11.7s run time
2025-08-16T03:31:28.108Z
Timed out retrying after 10000ms: Expected to find content: 'Invite Users' but never did.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Aug 14, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants