-
Notifications
You must be signed in to change notification settings - Fork 3.2k
bug(security): removed View Analytics from all users and blocked acce… #14453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ss to privileged routes
✅ Meticulous spotted visual differences in 72 of 1479 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit 5a781ca. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 1.78kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
❌ 11 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Summary: security fix to block exposed urls
Addresses:
Note:
/analytics
in https://docs.datahub.com/docs/authorization/roles was wrong, updated/settings
redirects to the default route (/settings/preferences
)