feat(actions): add DomainNameResolver for human-friendly domain names #14355
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds DomainNameResolver class to resolve domain URNs to human-readable display names in datahub-actions messages, improving user experience by showing friendly domain names instead of technical identifiers. Resolves: acryldata/datahub-actions#65 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
community-contribution
datahub-cyborg
bot
added
the
needs-review
|
Thanks for raising the PR! @hsheth2 could you take a look at this? |
datahub-cyborg
bot
added
pending-submitter-response
hsheth2
reviewed
Aug 7, 2025
Adds 10 unit test cases covering DomainNameResolver functionality: - Tests with/without DataHubGraph scenarios - Validates fallback behavior for missing/empty domain properties - Verifies NameResolverRegistry integration - Tests edge cases including None and empty string names - Ensures proper mocking and API contract verification All tests pass and follow existing code patterns and conventions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixes type error where DomainPropertiesClass constructor was passed None for name parameter. Uses Mock object with name attribute set to None instead to satisfy type checking. All tests continue to pass and mypy reports success with no issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
datahub-cyborg
bot
added
needs-review
hsheth2
reviewed
Aug 8, 2025
There was a problem hiding this comment.
these tests look extremely verbose - I was expecting something more like ~50 lines of code for the tests
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
hsheth2
requested changes
Aug 15, 2025
| assert entity_name == "Marketing Domain" | ||
|
|
||
|
|
||
| def test_domain_name_resolver_with_graph_and_empty_string_name(): |
There was a problem hiding this comment.
this test is also not necessary imo
Comment on lines
38
to
75
| def test_domain_name_resolver_with_graph_no_properties(): | ||
| """Test DomainNameResolver when DataHubGraph is available but no properties found""" | ||
| resolver = DomainNameResolver() | ||
| domain_urn = Urn.from_string("urn:li:domain:marketing-domain") | ||
|
|
||
| # Mock DataHubGraph that returns None for domain properties | ||
| mock_graph = Mock() | ||
| mock_graph.get_aspect.return_value = None | ||
|
|
||
| entity_name = resolver.get_entity_name(domain_urn, mock_graph) | ||
|
|
||
| # Should call get_aspect with correct parameters | ||
| mock_graph.get_aspect.assert_called_once_with( | ||
| str(domain_urn), DomainPropertiesClass | ||
| ) | ||
|
|
||
| # Should fallback to the domain ID from the URN | ||
| assert entity_name == "marketing-domain" | ||
|
|
||
| def test_domain_name_resolver_with_graph_and_properties(): | ||
| """Test DomainNameResolver when DataHubGraph returns properties with name""" | ||
| resolver = DomainNameResolver() | ||
| domain_urn = Urn.from_string("urn:li:domain:marketing-domain") | ||
|
|
||
| # Mock DataHubGraph that returns domain properties with a friendly name | ||
| mock_graph = Mock() | ||
| mock_properties = DomainPropertiesClass(name="Marketing Domain") | ||
| mock_graph.get_aspect.return_value = mock_properties | ||
|
|
||
| entity_name = resolver.get_entity_name(domain_urn, mock_graph) | ||
|
|
||
| # Should call get_aspect with correct parameters | ||
| mock_graph.get_aspect.assert_called_once_with( | ||
| str(domain_urn), DomainPropertiesClass | ||
| ) | ||
|
|
||
| # Should return the friendly name from properties | ||
| assert entity_name == "Marketing Domain" |
There was a problem hiding this comment.
these two tests look extremely similar - can you reduce the code duplication?
There was a problem hiding this comment.
Sure, collapsed the two testing scenarios into one.
|
|
||
| entity_name = resolver.get_entity_name(domain_urn, mock_graph) | ||
|
|
||
| # Should call get_aspect with correct parameters |
There was a problem hiding this comment.
these comments + docstrings are a bit overzealous. in general, comments should add new information and not just reexplain individual lines of code
There was a problem hiding this comment.
Sure, removed the extra comments.
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DomainNameResolver class to resolve domain URNs to human-readable display names in datahub-actions messages, improving user experience by showing friendly domain names instead of technical identifiers.
Resolves: acryldata/datahub-actions#65