feat(mysql): add support for stored procedures in mysql ingestion #14274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chema) to SQLAlchemySource
…to increase reusability of code
github-actions
bot
added
ingestion
…for subclass configs
…/datahub into stored-procedures-in-sql-common merge
datahub-cyborg
bot
added
the
needs-review
|
Thanks for the contribution! The assigned reviewer is out this week, so we’ll likely take a look after next week. Appreciate your patience! |
datahub-cyborg
bot
added
pending-submitter-response
sgomezvillamor
approved these changes
Aug 11, 2025
datahub-cyborg
bot
added
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golden files for mysql integration have been updated to account for the change and the added support for stored procedures.
The key change here is adding support for stored procedures directly in SQLAlchemySource, it does not interferere with any existing classes that inherit from SQLAlchemy source and if a class chooses to add support for stored procedures all they need to do is override get_procedures_for_schema and return a list of BaseProcedures which is handled by the existing code within SQLAlchemySource. I had originally made a pull request that added support directly in PostgresSource but I got rid of that and moved it over to SQLAlchemy (except for get_procedures_for_schema) to account for the change.