Skip to content

Conversation

acrylJonny
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 21, 2025
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gestion/src/datahub/ingestion/source/abs/source.py 50.00% 1 Missing ⚠️
...ngestion/src/datahub/ingestion/source/s3/source.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 21, 2025
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I just left some minor non-blocking comments

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jul 22, 2025
@acrylJonny acrylJonny merged commit a679ffc into master Jul 22, 2025
68 of 69 checks passed
@acrylJonny acrylJonny deleted the align-add_partition_columns_to_schema branch July 22, 2025 17:36
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants