Skip to content

Conversation

chriscollins3456
Copy link
Collaborator

Shows the user role on the new custom home page behind a feature flag. By default we don't want this on for folks, but some people very much want this so they can enable it with a flag.

With flag on
image

With flag off
image

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Jul 18, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 18, 2025
Copy link

alwaysmeticulous bot commented Jul 18, 2025

🔴 Meticulous spotted visual differences in 284 of 1550 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 3c39b73. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jul 18, 2025

Bundle Report

Changes will increase total bundle size by 96 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.23MB 96 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 96 bytes 18.6MB 0.0%

Files in assets/index-*.js:

  • ./src/app/homeV3/header/components/GreetingText.tsx → Total Size: 1.01kB

  • ./src/alchemy-components/components/PageTitle/PageTitle.tsx → Total Size: 594 bytes

  • ./src/appConfigContext.tsx → Total Size: 2.27kB

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jul 18, 2025
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/homeV3/header/components/GreetingText.tsx 22.22% 7 Missing ⚠️
...ub/graphql/resolvers/config/AppConfigResolver.java 0.00% 1 Missing ⚠️
...hemy-components/components/PageTitle/PageTitle.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@chriscollins3456 chriscollins3456 merged commit 8ad23a6 into master Jul 21, 2025
44 of 47 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--ch-569-home-page-subtitle branch July 21, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants