Skip to content

Conversation

purnimagarg1
Copy link
Collaborator

@purnimagarg1 purnimagarg1 commented Jul 18, 2025

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jul 18, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 18, 2025
Copy link

codecov bot commented Jul 18, 2025

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error parsing JUnit XML in /home/runner/work/datahub/datahub/metadata-io/build/test-results/test/TEST-com.linkedin.metadata.graph.search.elasticsearch.SearchGraphServiceElasticSearchTest.xml at 683:1058

Caused by:
RuntimeError: Error converting computed name to ValidatedString

Caused by:
    string is too long</code></pre>

For more help, visit our troubleshooting guide.


:x: 4 Tests Failed:

Tests completed Failed Passed Skipped
6222 4 6218 70
View the full list of 3 :snowflake: flaky tests
tests.lineage.test_lineage_sdk::test_column_level_lineage_from_schema_field

Flake rate in main: 6.67% (Passed 84 times, Failed 6 times)

Stack Traces | 0.02s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f33e186af90>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_column_level_lineage_from_schema_field(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        source_schema_field = SchemaFieldUrn(test_datasets["upstream"].urn, "id")
        column_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(source_schema_field), direction="downstream", max_hops=3
        )
    
>       assert len(column_lineage_results) == 3
E       assert 0 == 3
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:203: AssertionError
tests.lineage.test_lineage_sdk::test_filtered_column_level_lineage

Flake rate in main: 6.67% (Passed 84 times, Failed 6 times)

Stack Traces | 0.02s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f33e186af90>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_filtered_column_level_lineage(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        filtered_column_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(test_datasets["upstream"].urn),
            source_column="id",
            direction="downstream",
            max_hops=3,
            filter=F.and_(F.platform("mysql"), F.entity_type("dataset")),
        )
    
>       assert len(filtered_column_lineage_results) == 1
E       assert 0 == 1
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:185: AssertionError
tests.lineage.test_lineage_sdk::test_table_level_lineage

Flake rate in main: 6.67% (Passed 84 times, Failed 6 times)

Stack Traces | 0.164s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f33e186af90>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_table_level_lineage(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        table_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(test_datasets["upstream"].urn),
            direction="downstream",
            max_hops=3,
        )
    
>       assert len(table_lineage_results) == 3
E       assert 0 == 3
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:109: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

alwaysmeticulous bot commented Jul 18, 2025

🔴 Meticulous spotted visual differences in 123 of 1589 screens tested: view and approve differences detected.

Meticulous evaluated ~10 hours of user flows against your PR.

Last updated for commit 671b0a8. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jul 18, 2025

Bundle Report

Changes will increase total bundle size by 3.36kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.23MB 3.36kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 3.36kB 18.59MB 0.02%

Files in assets/index-*.js:

  • ./src/app/homeV3/module/components/ModuleContainer.tsx → Total Size: 713 bytes

  • ./src/app/homeV3/modules/link/LinkForm.tsx → Total Size: 938 bytes

  • ./src/app/homeV3/module/components/ModuleMenu.tsx → Total Size: 1.49kB

  • ./src/app/homeV3/modules/constants.ts → Total Size: 2.83kB

  • ./src/app/homeV3/modules/link/LinkModal.tsx → Total Size: 1.54kB

  • ./src/app/homeV3/module/components/SmallModule.tsx → Total Size: 862 bytes

  • ./src/app/homeV3/module/components/LargeModule.tsx → Total Size: 2.42kB

  • ./src/app/homeV3/styledComponents.ts → Total Size: 1.56kB

  • ./src/app/homeV3/module/Module.tsx → Total Size: 834 bytes

  • ./src/app/homeV3/template/components/addModuleMenu/useAddModuleMenu.tsx → Total Size: 4.65kB

  • ./src/app/homeV3/moduleModals/ModuleModalMapper.tsx → Total Size: 706 bytes

  • ./src/app/homeV3/modules/link/LinkModule.tsx → Total Size: 1.94kB

  • ./src/app/homeV3/moduleModals/common/BaseModuleModal.tsx → Total Size: 862 bytes

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks solid! i made some minor tweaks and there's one major thing i'm noticing that differs from your screenshots, so maybe merging in master broke something: it looks like there's no small rows anymore, instead there's just a lot of empty whitespace underneath a link with the same height as a large row

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jul 18, 2025
@chriscollins3456 chriscollins3456 merged commit 0c74310 into master Jul 18, 2025
73 of 77 checks passed
@chriscollins3456 chriscollins3456 deleted the pg--ch-517-support-link-module branch July 18, 2025 19:32
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
…ge (datahub-project#14141)

Co-authored-by: Chris Collins <chriscollins3456@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants