-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(homepage): Add support for Quick Link modules in the new home page #14141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b61f595
to
63d77d2
Compare
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
|
🔴 Meticulous spotted visual differences in 123 of 1589 screens tested: view and approve differences detected. Meticulous evaluated ~10 hours of user flows against your PR. Last updated for commit 671b0a8. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 3.36kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks solid! i made some minor tweaks and there's one major thing i'm noticing that differs from your screenshots, so maybe merging in master broke something: it looks like there's no small rows anymore, instead there's just a lot of empty whitespace underneath a link with the same height as a large row
…ge (datahub-project#14141) Co-authored-by: Chris Collins <chriscollins3456@gmail.com>
Linear tickets:
https://linear.app/acryl-data/issue/CH-517/add-ability-to-add-link-module
https://linear.app/acryl-data/issue/CH-518/ability-to-view-link-module-on-homepage
https://linear.app/acryl-data/issue/CH-521/ability-to-edit-link-module
Screenshots: