feat(logical): Add feature flag and models #14097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
|
datahub-cyborg
bot
added
the
needs-review
|
✅ Meticulous spotted 0 visual differences across 1453 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 555be1c. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 51 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
gabe-lyons
reviewed
Jul 15, 2025
Comment on lines
9
to
10
| @Relationship = { | ||
| "/destinationUrn": { |
There was a problem hiding this comment.
Huh I thought I got rid of this, nice catch
gabe-lyons
reviewed
Jul 15, 2025
| record LogicalParent { | ||
| @Relationship = { | ||
| "/destinationUrn": { | ||
| "name": "LogicalInstanceOf", |
There was a problem hiding this comment.
I think the relationship is PhysicalInstanceOf - I am a physical instance of a my logical parent.
gabe-lyons
reviewed
Jul 15, 2025
| "queryByDefault": false, | ||
| "addToFilters": true, | ||
| "hasValuesFieldName": "hasLogicalParent", | ||
| "filterNameOverride": "Logical Instance Of" |
gabe-lyons
approved these changes
Jul 15, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
|
Merging through flake |
kartikey-visa
pushed a commit
to kartikey-visa/datahub
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to support logical models, i.e. representing the relationship between logical dataset and their physical representations