Skip to content

Conversation

brock-acryl
Copy link
Contributor

added googlebigquery -> bigquery mapping for sql parsing with tableau custom queries.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
3220 4 3216 45
View the full list of 3 ❄️ flaky tests
tests.lineage.test_lineage_sdk::test_filtered_column_level_lineage

Flake rate in main: 8.33% (Passed 44 times, Failed 4 times)

Stack Traces | 0.013s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f3a8ebfb490>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_filtered_column_level_lineage(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        filtered_column_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(test_datasets["upstream"].urn),
            source_column="id",
            direction="downstream",
            max_hops=3,
            filter=F.and_(F.platform("mysql"), F.entity_type("dataset")),
        )
    
>       assert len(filtered_column_lineage_results) == 1
E       assert 0 == 1
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:185: AssertionError
tests.lineage.test_lineage_sdk::test_column_level_lineage_from_schema_field

Flake rate in main: 8.33% (Passed 44 times, Failed 4 times)

Stack Traces | 0.014s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f3a8ebfb490>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_column_level_lineage_from_schema_field(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        source_schema_field = SchemaFieldUrn(test_datasets["upstream"].urn, "id")
        column_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(source_schema_field), direction="downstream", max_hops=3
        )
    
>       assert len(column_lineage_results) == 3
E       assert 0 == 3
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:203: AssertionError
tests.lineage.test_lineage_sdk::test_table_level_lineage

Flake rate in main: 8.33% (Passed 44 times, Failed 4 times)

Stack Traces | 0.161s run time
test_client = <datahub.sdk.main_client.DataHubClient object at 0x7f3a8ebfb490>
test_datasets = {'downstream1': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_downstream_001,PROD)'), 'downstrea...ream_003,PROD)'), 'upstream': Dataset('urn:li:dataset:(urn:li:dataPlatform:snowflake,test_lineage_upstream_001,PROD)')}

    def test_table_level_lineage(
        test_client: DataHubClient, test_datasets: Dict[str, Dataset]
    ):
        table_lineage_results = test_client.lineage.get_lineage(
            source_urn=str(test_datasets["upstream"].urn),
            direction="downstream",
            max_hops=3,
        )
    
>       assert len(table_lineage_results) == 3
E       assert 0 == 3
E        +  where 0 = len([])

tests/lineage/test_lineage_sdk.py:109: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@brock-acryl brock-acryl marked this pull request as ready for review July 15, 2025 16:10
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 15, 2025
Copy link
Contributor

@ligfx ligfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also going to match connection_types like:

  • google
  • glebigqu
    etc.

Should be

elif connection_type in ("googlebigquery",):

or

elif connection_type == "googlebigquery":

(And yes the other two above it are similarly broken.)

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jul 15, 2025
@brock-acryl brock-acryl requested a review from ligfx July 16, 2025 02:02
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jul 16, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jul 16, 2025
@brock-acryl brock-acryl merged commit b1c3d33 into master Jul 16, 2025
59 of 60 checks passed
@brock-acryl brock-acryl deleted the fix(ingestion/tableau)-bigquery-mapping branch July 16, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants