-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(graphql) Add deletePageModule GraphQL resolver #14000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 6 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
entityClient.deleteEntity(opContext, moduleUrn); | ||
|
||
// Asynchronously delete all references to the entity (to return quickly) | ||
CompletableFuture.runAsync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a question: should we handle somehow the case when the module was deleted but references steel there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should indeed. i'll create a ticket for this
This PR creates a new graphql endpoint for deleting page modules. There are a few stipulations:
There is a ticket for adding the manage permissions for modules that will update the logic here and a few other places soon.