feat: update fivetran connector with new sdk #13859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
yoonhyejin
commented
Jun 25, 2025
| @@ -134,7 +137,22 @@ def __init__( | |||
| self._setdefault_aspect(job_info) | |||
| self._ensure_datajob_props().flowUrn = str(flow.urn) | |||
|
|
|||
| # Set properties if provided | |||
| self._init_basic_props( | |||
There was a problem hiding this comment.
separated these to avoid mypy error (init is too complex)
yoonhyejin
commented
Jun 25, 2025
| @@ -103,12 +104,14 @@ def __init__( | |||
| ValueError: If neither flow nor (flow_urn and platform_instance) are provided | |||
| """ | |||
| if flow is None: | |||
| if flow_urn is None or platform_instance is None: | |||
| if flow_urn is None: | |||
There was a problem hiding this comment.
fixed bug ; platform_instance is not strictly needed
yoonhyejin
commented
Jun 25, 2025
| @@ -237,21 +237,6 @@ def test_datajob_init_with_flow_urn() -> None: | |||
|
|
|||
|
|
|||
| def test_invalid_init() -> None: | |||
| flow = DataFlow( | |||
There was a problem hiding this comment.
removed tests as we fixed bug above
yoonhyejin
commented
Jun 25, 2025
| flow_urn=datajob.flow_urn, | ||
| platform_instance=self.config.platform_instance, | ||
| name=datajob.name, | ||
| ) | ||
| return DataProcessInstance.from_datajob( |
There was a problem hiding this comment.
eh this is very hacky and i don't like this solution, but seems like we need to do a lot of job with api.entities.dataprocessinstance code to be compatible with the SDK v2. i'd rather just add DPI to SDK v2 rather than trying to make this compatible.
Bundle ReportChanges will increase total bundle size by 77 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
yoonhyejin
commented
Jun 26, 2025
| "ownerTypes": {}, | ||
| "lastModified": { | ||
| "time": 0, | ||
| "actor": "urn:li:corpuser:unknown" |
There was a problem hiding this comment.
i'm not sure where this is coming from -- this should be corpuser:fivetran
hsheth2
reviewed
Jun 26, 2025
metadata-ingestion/src/datahub/ingestion/source/fivetran/fivetran.py
Outdated
Show resolved
Hide resolved
| @@ -134,7 +137,22 @@ def __init__( | |||
| self._setdefault_aspect(job_info) | |||
| self._ensure_datajob_props().flowUrn = str(flow.urn) | |||
|
|
|||
| # Set properties if provided | |||
| self._init_basic_props( | |||
metadata-ingestion/src/datahub/ingestion/source/fivetran/fivetran.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
hsheth2
approved these changes
Jun 30, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
kartikey-visa
pushed a commit
to kartikey-visa/datahub
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.