Skip to content

feat(ingest): update mlflow connector with new sdk v2 #13857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat(ingest): update mlflow connector with new sdk v2 #13857

wants to merge 8 commits into from
+220 −210

Conversation

yoonhyejin
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 25, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025

Bundle Report

Changes will increase total bundle size by 77 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.69MB 77 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 77 bytes 16.06MB 0.0%

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

yoonhyejin
yoonhyejin commented Jun 25, 2025
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/mlflow.py
@@ -789,34 +743,36 @@ def _get_ml_model_properties_workunit(
training_metrics = None
training_jobs = []

created_time = model_version.creation_timestamp
created_actor = (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need to add this to the mlmodel entity

@yoonhyejin yoonhyejin marked this pull request as ready for review June 26, 2025 10:31
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jun 26, 2025
hsheth2
hsheth2 reviewed Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure there's no behavior changes

metadata-ingestion/tests/unit/test_mlflow_source.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update golden file diff checker ignore rules

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jun 26, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jun 27, 2025
hsheth2
hsheth2 reviewed Jun 30, 2025
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/mlflow.py Outdated
@@ -699,13 +713,12 @@ def _get_mlflow_run(self, model_version: ModelVersion) -> Union[None, Run]:
else:
return None

def _get_ml_model_workunits(self) -> Iterable[MetadataWorkUnit]:
def _get_ml_model_workunits(self) -> Iterable[Union[MetadataWorkUnit, Entity]]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this still need MetadataWorkUnit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yield self._get_global_tags_workunit(model_version=model_version) this still returns MetadataWorkUnit

metadata-ingestion/tests/integration/mlflow/mlflow_mcps_golden.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having trouble reading through the diff here. Are there any important changes that we need to look at here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pushed one fix for tags -- we don't really use HasTag for mlmodel "tags" -- we just push them to mlmodelproperties.tags

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jun 30, 2025
@yoonhyejin yoonhyejin requested a review from hsheth2 July 2, 2025 13:10
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jul 2, 2025
hsheth2
hsheth2 reviewed Jul 2, 2025
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/mlflow.py
model_group=ml_model_group_urn,
training_jobs=training_jobs,
extra_aspects=[MLModelPropertiesClass(tags=model_version_tags)],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what were the results of your investigation? where is the right spot to put tags?

imo our MLModel should handle any discrepancies by overriding the methods from HasTags. The user should not need to deal with these details. In other words - this feels like a bug in our MLModel sdk

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jul 2, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jul 3, 2025
@hsheth2
Copy link
Collaborator

hsheth2 commented Jul 16, 2025

@yoonhyejin looks like lint is failing

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2