Skip to content

fix(ui/table): Fix column / ml feature description show more button #13525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

asikowitz
Copy link
Collaborator

@asikowitz asikowitz commented May 15, 2025

Simplifies code by no longer managing state higher up to coordinate show more state between schema field drawer and table.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 15, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../components/SchemaFieldDrawer/FieldDescription.tsx 0.00% 2 Missing ⚠️
...ema/components/SchemaFieldDrawer/AboutFieldTab.tsx 0.00% 1 Missing ⚠️
...Documentation/components/CompactMarkdownViewer.tsx 66.66% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (73.33%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

Copy link

alwaysmeticulous bot commented May 15, 2025

🔴 Meticulous spotted visual differences in 3 of 1270 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 42b2100. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 15, 2025
@asikowitz asikowitz merged commit 53c25ad into master May 15, 2025
30 of 33 checks passed
@asikowitz asikowitz deleted the fix-table-description-show-more branch May 15, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants