feat(ingest/snowflake): generate lineage through temp views #13517
+149
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
gabe-lyons
reviewed
May 14, 2025
Comment on lines
-46
to
-52
| ACCESS_HISTORY_TABLE_DOMAINS_FILTER = ( | ||
| "(" | ||
| f"'{SnowflakeObjectDomain.TABLE.capitalize()}'," | ||
| f"'{SnowflakeObjectDomain.VIEW.capitalize()}'," | ||
| f"'{SnowflakeObjectDomain.STREAM.capitalize()}'," | ||
| ")" | ||
| ) |
There was a problem hiding this comment.
so this was just unused ?
There was a problem hiding this comment.
yup - it was an unrelated cleanup
datahub-cyborg
bot
added
the
pending-submitter-response
hsheth2
force-pushed
the
snowflake-temp-views
branch
from
fda2c94 to
3217f35
Compare
datahub-cyborg
bot
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #13383
Still pending