Skip to content

fix(sdk): change deprecated value use #13511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

anshbansal
Copy link
Collaborator

In our monitoring was seeing this error

Deprecated use of a filter using Criterion's `value` has been detected and corrected. Please migrate to `values` instead.

Changing a few places where I saw value in filter. I have not tested this locally. I am assuming that we have automated tests for these places. Will let CI tell me if I am wrong here.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 14, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 14, 2025
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
metadata-ingestion/src/datahub/api/graphql/base.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 14, 2025
@anshbansal anshbansal merged commit 1991441 into master May 15, 2025
2 checks passed
@anshbansal anshbansal deleted the ab-2025-may-14-deprecated-val-fix branch May 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants