Skip to content

feat(ingestion/looker): extract group_labels from looker and add as tags in datahub #13503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 14, 2025
Merged

feat(ingestion/looker): extract group_labels from looker and add as tags in datahub #13503

merged 7 commits into from
May 14, 2025

Conversation

acrylJonny
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 13, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 13, 2025
@codecov Codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/datahub/ingestion/source/looker/looker_common.py 66.66% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels May 14, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels May 14, 2025
sgomezvillamor
sgomezvillamor approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Up to you final decision on tag pattern :-)

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 14, 2025
@acrylJonny acrylJonny merged commit c756af3 into master May 14, 2025
61 of 62 checks passed
@acrylJonny acrylJonny deleted the looker-group_label branch May 14, 2025 12:08
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
@acrylJonny @kartikey-visa
feat(ingestion/looker): extract group_labels from looker and add as t…
f48ee3d 
…ags in datahub (datahub-project#13503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees

No one assigned

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acrylJonny @sgomezvillamor