fix(ingest/presto): Presto/Trino property extraction fix #13487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
❌ Your patch status has failed because the patch coverage (31.81%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
treff7es
force-pushed
the
presto_catalog_name_workaround
branch
from
26ea1d0 to
5735636
Compare
treff7es
changed the title
hsheth2
approved these changes
May 12, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
treff7es
force-pushed
the
presto_catalog_name_workaround
branch
from
5735636 to
b03578a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for Presto to not fail on missing system column
Unfortunately, the Presto dialect provides catalog_name as a column; therefore, we need a workaround to avoid failure.
This is a workaround not to fail, which causes only the table comment to be returned as a property, which is still better than failing.
Fix Trino property extraction from Iceberg tables