fix(authentication) redirection for native login and sso to function within iframes #13453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly in iframes now
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
|
✅ Meticulous spotted visual differences in 3 of 1383 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit 6ca8c1d. This comment will update as new commits are pushed. |
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
jjoyce0510
approved these changes
May 8, 2025
esteban
added a commit
that referenced
this pull request
May 8, 2025
…within iframes (#13453) Co-authored-by: Esteban Gutierrez <esteban.gutierrez@acryl.io>
jayacryl
commented
Jul 7, 2025
| redirectCookieBuilder.withSecure(true); | ||
| redirectCookieBuilder.withHttpOnly(true); | ||
| redirectCookieBuilder.withMaxAge(Duration.ofSeconds(86400)); | ||
| redirectCookieBuilder.withSameSite(Http.Cookie.SameSite.NONE); |
There was a problem hiding this comment.
kartikey-visa
pushed a commit
to kartikey-visa/datahub
that referenced
this pull request
Jul 23, 2025
…within iframes (datahub-project#13453) Co-authored-by: Esteban Gutierrez <esteban.gutierrez@acryl.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful for the chrome extension