Skip to content

Conversation

asikowitz
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label May 2, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 2, 2025
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

# Depot is used here for remote container builds in base_build and also for all runners. Depot runners support unlimited concurrency
# and hence short queue times and higher parallelism of smoke tests

run: |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:2:3: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

# Depot is used here for remote container builds in base_build and also for all runners. Depot runners support unlimited concurrency
# and hence short queue times and higher parallelism of smoke tests

run: |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:7:3: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

- id: download_image
name: Download images from depot
if: ${{ needs.setup.outputs.use_depot_cache == 'true' }}
run: |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:117: Double quote to prevent globbing and word splitting [shellcheck]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
property "run-publish-images" is not defined in object type {ci-optimize: {conclusion: string; outcome: string; outputs: {actions-change: string; backend-change: string; backend-only: string; docker-change: string; elasticsearch-setup-change: string; frontend-change: string; frontend-only: string; ingestion-base-change: string; ingestion-change: string; ingestion-only: string; kafka-setup-change: string; mysql-setup-change: string; postgres-setup-change: string; smoke-test-change: string}}; docker-login: {conclusion: string; outcome: string; outputs: {string => string}}; pr-publish: {conclusion: string; outcome: string; outputs: {string => string}}; publish: {conclusion: string; outcome: string; outputs: {string => string}}; set-runner: {conclusion: string; outcome: string; outputs: {string => string}}; tag: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]

run_publish_images: ${{ steps.run-publish-images.outputs.run_publish_images}}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:115: Double quote to prevent globbing and word splitting [shellcheck]

python-version: "3.10"
- name: run prettier --check
run: |-
./gradlew :datahub-web-react:githubActionsPrettierCheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we'd use something like this https://github.com/pre-commit/action

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels May 3, 2025
@asikowitz asikowitz merged commit eb41e0b into master May 5, 2025
35 checks passed
@asikowitz asikowitz deleted the add-yaml-format-check branch May 5, 2025 23:21
esteban pushed a commit that referenced this pull request May 9, 2025
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants