-
Notifications
You must be signed in to change notification settings - Fork 3.2k
ci: Add yaml format check #13407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add yaml format check #13407
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
# Depot is used here for remote container builds in base_build and also for all runners. Depot runners support unlimited concurrency | ||
# and hence short queue times and higher parallelism of smoke tests | ||
|
||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:2:3: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]
# Depot is used here for remote container builds in base_build and also for all runners. Depot runners support unlimited concurrency | ||
# and hence short queue times and higher parallelism of smoke tests | ||
|
||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:7:3: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]
- id: download_image | ||
name: Download images from depot | ||
if: ${{ needs.setup.outputs.use_depot_cache == 'true' }} | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:117: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [actionlint] reported by reviewdog 🐶
property "run-publish-images" is not defined in object type {ci-optimize: {conclusion: string; outcome: string; outputs: {actions-change: string; backend-change: string; backend-only: string; docker-change: string; elasticsearch-setup-change: string; frontend-change: string; frontend-only: string; ingestion-base-change: string; ingestion-change: string; ingestion-only: string; kafka-setup-change: string; mysql-setup-change: string; postgres-setup-change: string; smoke-test-change: string}}; docker-login: {conclusion: string; outcome: string; outputs: {string => string}}; pr-publish: {conclusion: string; outcome: string; outputs: {string => string}}; publish: {conclusion: string; outcome: string; outputs: {string => string}}; set-runner: {conclusion: string; outcome: string; outputs: {string => string}}; tag: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]
run_publish_images: ${{ steps.run-publish-images.outputs.run_publish_images}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:115: Double quote to prevent globbing and word splitting [shellcheck]
datahub/.github/workflows/docker-unified.yml
Line 248 in 585cad2
run: | |
python-version: "3.10" | ||
- name: run prettier --check | ||
run: |- | ||
./gradlew :datahub-web-react:githubActionsPrettierCheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we'd use something like this https://github.com/pre-commit/action
No description provided.