Skip to content

fix(web) set domain dropdown ui to match domains page #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(web) set domain dropdown ui to match domains page #13294

wants to merge 6 commits into from
+38 −12

Conversation

jayacryl
Copy link
Collaborator

@jayacryl jayacryl commented Apr 22, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Apr 22, 2025
@jayacryl jayacryl requested a review from sakethvarma397 April 22, 2025 23:47
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
110 1 109 0
View the top 1 failed test(s) by shortest run time 
Verify nested domains test functionalities cypress/e2e/domains/nested_domains.js cypress/e2e/domains/nested_domains.js
Stack Traces | 16.5s run time 
2025-04-23T00:19:16.168Z
Timed out retrying after 10000ms: Expected to find content: 'CypressNestedDomain' but never did.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Apr 22, 2025
sakethvarma397
sakethvarma397 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@sakethvarma397 sakethvarma397 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Apr 23, 2025
chriscollins3456
chriscollins3456 reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how this could be causing nested_domains.js to fail but i'm not seeing this failure necessarily on other cypress tests and you are touching domains so it might be worth double checking into it

@jayacryl jayacryl changed the title fix(web) clean up domains ui fix(web) set domain dropdown ui to match domains page May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 left review comments

@sakethvarma397 sakethvarma397 sakethvarma397 approved these changes

Assignees
No one assigned
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayacryl @chriscollins3456 @sakethvarma397