-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(ingest/mysql): support stored procedures #12356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mayuri added nicer abstractions for stored procedures in #12929 - we should use those
It also looks like there's a bunch of copy-pasted code. In general, if you're copy pasting code you're doing something wrong.
changes now made to conform with the newer stored proc approach |
Checklist