Skip to content

feat(ingest/mysql): support stored procedures #12356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

acrylJonny
Copy link
Collaborator

@acrylJonny acrylJonny commented Jan 15, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@acrylJonny acrylJonny marked this pull request as draft January 15, 2025 17:14
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 92.11356% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...n/src/datahub/ingestion/source/sql/mysql/source.py 92.70% 10 Missing ⚠️
...c/datahub/ingestion/source/sql/mysql/job_models.py 92.17% 9 Missing ⚠️
...estion/src/datahub/ingestion/source/sql/mariadb.py 90.62% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@acrylJonny acrylJonny marked this pull request as ready for review January 24, 2025 23:01
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 24, 2025
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mayuri added nicer abstractions for stored procedures in #12929 - we should use those

It also looks like there's a bunch of copy-pasted code. In general, if you're copy pasting code you're doing something wrong.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Mar 26, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels May 14, 2025
@acrylJonny
Copy link
Collaborator Author

Mayuri added nicer abstractions for stored procedures in #12929 - we should use those

It also looks like there's a bunch of copy-pasted code. In general, if you're copy pasting code you're doing something wrong.

changes now made to conform with the newer stored proc approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants