Skip to content

feat(ingestion/sql-common): add column level lineage for external tables #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

acrylJonny
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@acrylJonny acrylJonny marked this pull request as draft December 2, 2024 10:29
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 2, 2024
@acrylJonny acrylJonny changed the title feat(ingestion/sql-common): column level lineage for external tables feat(ingestion/sql-common): add column level lineage for external tables Dec 2, 2024
@acrylJonny acrylJonny marked this pull request as ready for review December 2, 2024 13:36
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 2, 2024
@anshbansal anshbansal removed the community-contribution PR or Issue raised by member(s) of DataHub Community label Dec 4, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 18, 2024
@hsheth2
Copy link
Collaborator

hsheth2 commented Dec 30, 2024

Now that #12220 has been merged, we can make this implementation be a bit cleaner.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 30, 2024
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ion/src/datahub/ingestion/source/sql/sql_common.py 70.83% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (72.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 14, 2025
@acrylJonny
Copy link
Collaborator Author

Now that #12220 has been merged, we can make this implementation be a bit cleaner.

Now refactored to align with updates in #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants