feat: add helper tooltip to display why suggest tags button is not available #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinocroustibat
requested review from
ThibaudDauce,
maudetes and
nicolaskempf57
as code owners
bolinocroustibat
force-pushed
the
suggest-tags-tooltip
branch
from
abce634 to
858a021
Compare
ThibaudDauce
approved these changes
Jan 27, 2026
| :icon="RiSparklingLine" | ||
| :loading="isGeneratingTags" | ||
| :disabled="!canGenerateTags" | ||
| :disabled="!!tagsSuggestionDisabledMessage" |
Contributor
There was a problem hiding this comment.
if there is tagsSuggestionDisabledMessage this button is never rendered
Contributor
Author
There was a problem hiding this comment.
Not sure I get you; the "normal" (not the disabled) BrandedButton component is in he v-else condition, so it is rendered when tagsSuggestionDisabledMessage is empty. But we can actully get rid of :disabled="!!tagsSuggestionDisabledMessage" which is redundant
Contributor
There was a problem hiding this comment.
Yes, disabled is never true since it's in the v-else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tooltip to explain why tag suggestion button is disabled
Adds a tooltip to the tag suggestion button in DescribeDataset.vue to explain why it's disabled, matching the behavior of the short description suggestion button and of #884.
The tooltip shows:
This improves UX by clarifying why the feature is unavailable.