feat(a11y): plan du site RGAA 12.1#204
Open
skelz0r wants to merge 1 commit into
Open
Conversation
skelz0r
force-pushed
the
develop
branch
2 times, most recently
from
d11e169 to
538b030
Compare
skelz0r
force-pushed
the
site/a11y-sitemap
branch
from
ba688dd to
a3ddc68
Compare
RGAA 12.1 requires two navigation systems; we had a header nav but no sitemap (the footer link was a dead `href="#"`). This adds: - `config/sitemap.yml` — authoritative list of public pages for both API Entreprise and API Particulier, grouped by section. Each entry references a route by its helper name, not a hardcoded path, so links follow automatically when a route's path changes (same convention as changelogs). - `/plan-du-site` route + `pages#sitemap` action in both namespaces. - `shared/pages/sitemap.html.erb` — shared view resolving each entry via its route helper. - Footer links updated from `href="#"` to the real path helper. - `spec/features/sitemap_spec.rb` — visits both /plan-du-site pages; since rendering resolves every route helper, a removed or renamed route blows up the page and fails the spec, with no separate route check to maintain. Closes https://linear.app/datagouv/issue/API-6732
skelz0r
force-pushed
the
site/a11y-sitemap
branch
from
a3ddc68 to
6828197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RGAA 12.1 — plan du site fonctionnel (le lien footer pointait vers `href="#"`).
`config/sitemap.yml` source de vérité unique (sections + chemins + titres), rendu par une vue partagée, protégé par un spec qui valide chaque chemin contre le routeur Rails — impossible d'ajouter une page sans route sans casser la CI.
Closes API-6732