Feat/api allocation rentree scolaire#164
Open
Samuelfaure wants to merge 17 commits into
Open
Conversation
Samuelfaure
commented
Jun 2, 2026
Samuelfaure
commented
Jun 2, 2026
Samuelfaure
force-pushed
the
feat/api_allocation_rentree_scolaire
branch
from
22794ff to
821bf72
Compare
skelz0r
requested changes
Jun 2, 2026
skelz0r
left a comment
skelz0r
left a comment
Member
There was a problem hiding this comment.
Quelques points rien de méchant. Je pense qu'on devrait harden la validation pour être sûr qu'on respecte le contrat d'interface (i.e. vérifier qu'on renvoi bien un code référencé).
Samuelfaure
force-pushed
the
feat/api_allocation_rentree_scolaire
branch
from
821bf72 to
a46f5b0
Compare
Contributor
Author
|
En attente du swagger + credentials pour clotûrer ici |
Member
comment ca en attente du swagger ? 😅 t'as dev les calls sans swagger ? |
Contributor
Author
|
@skelz0r J'ai le contrat d'interface |
Member
|
donc pas besoin du swagger à priori ? |
Contributor
Author
|
Me faudrait l'URL d'appel exacte (avec les credentials) pour vérifier les payloads dummy |
Samuelfaure
force-pushed
the
feat/api_allocation_rentree_scolaire
branch
from
a46f5b0 to
02d565d
Compare
Member
|
Pour trace: MeP 6 juillet |
Un3x
requested changes
Jun 25, 2026
Samuelfaure
force-pushed
the
feat/api_allocation_rentree_scolaire
branch
2 times, most recently
from
08632e2 to
df65eac
Compare
applied to all CNAV endpoints
Was pointing to /api/caf/ping; should point to /api/cnav_allocation_rentree_scolaire/ping to match the provider key declared in siade/config/pings.yml.
The 404.json fixture reused the "L'API n'existe pas" (40401) body copy-pasted from other CNAV endpoints, which describes a technical routing error rather than a genuine "dossier not found" case. Swapped it for the vendor-documented 40411 "Il n'a pas été possible de récupérer l'information sur la personne", per the API-Prestations swagger's error catalog. Body content doesn't drive the MSA/CNAF/ regime-less branches (they key off the X-APISECU-FD header and HTTP status), so behavior and existing test expectations are unchanged.
Samuelfaure
force-pushed
the
feat/api_allocation_rentree_scolaire
branch
from
1f168be to
4edec19
Compare
skelz0r
approved these changes
Jul 3, 2026
skelz0r
left a comment
skelz0r
left a comment
Member
There was a problem hiding this comment.
PI: Le message de commit de l'amélioration du ValidateResponse n'est pas assez clair.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Litérallement un claude one-shot
fix https://linear.app/pole-api/issue/API-5967/integrer-lapi