feat: include dataset information in 410 error message for deleted resources #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e has been deleted
Pierlou
reviewed
Oct 2, 2025
Contributor
Pierlou
left a comment
Pierlou
left a comment
There was a problem hiding this comment.
The flow looks good to me, just wondering about the best wording, do we want to redirect to the /discussions for instance?
Contributor
Author
I don't really have an opinion except maybe it's better to redirect the user to the index page as it's more expected, and it leaves choice to the user to go to the discussion tab or not? Any suggestion to improve the wording @maudetes? |
bolinocroustibat
force-pushed
the
dataset-id-in-410-error-message
branch
from
9de133e to
1be2acc
Compare
bolinocroustibat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to datagouv/data.gouv.fr#1862 and this discussion.
Needs datagouv/hydra#341