feat: HTTP response 410 on deleted resource #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinocroustibat
changed the title
bolinocroustibat
force-pushed
the
410-on-resource-deleted
branch
from
31bed00 to
88af390
Compare
bolinocroustibat
force-pushed
the
410-on-resource-deleted
branch
from
88af390 to
88a62cb
Compare
bolinocroustibat
force-pushed
the
410-on-resource-deleted
branch
2 times, most recently
from
24b4c8c to
d029532
Compare
bolinocroustibat
force-pushed
the
410-on-resource-deleted
branch
from
d029532 to
d4a203a
Compare
maudetes
approved these changes
Sep 24, 2025
Contributor
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
Thank you, looks clean!
| if record[0].get("deleted_at") is not None: | ||
| deleted_at: str = record[0]["deleted_at"] | ||
| raise web.HTTPGone( | ||
| text=f"Resource {resource_id} has been permanently deleted on {deleted_at} by its producer. Contact the resource producer to get more information." |
Contributor
There was a problem hiding this comment.
We could point towards the dataset maybe, for an incentive to create a discussion there?
The dataset may have been deleted as well though, leading to a 410 first and then a 404 when it has been finally purged.
Contributor
Author
There was a problem hiding this comment.
Totally, this is the plan, but since it's not in the same database it needs a migration to have this info in table_index, and more DB requests on hydra's side. As it is a bit trickier, it is currently being be considered in separate PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue datagouv/data.gouv.fr#1862.
Needs datagouv/hydra#340 to be merged first.