Skip to content

Yields endline after chunk #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2023
Merged

Yields endline after chunk #14

merged 5 commits into from
Sep 6, 2023

Conversation

@quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Sep 5, 2023 •
edited
Loading

fix #12

@quaxsze quaxsze requested a review from maudetes September 5, 2023 13:39
maudetes
maudetes reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quaxsze @maudetes
Update api_tabular/metrics.py
31e8f1e 
Co-authored-by: maudetes <maudet.estelle@gmail.com>
@quaxsze quaxsze requested a review from maudetes September 6, 2023 07:51
maudetes
maudetes approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@quaxsze quaxsze merged commit 003f95e into main Sep 6, 2023
@quaxsze quaxsze deleted the EndlineFix branch September 6, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maudetes maudetes maudetes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix newline on csv pagination

3 participants

@quaxsze @maudetes