Skip to content

feat: add --dir option for the cli #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Jun 6, 2025

The dir option allows user to load all supported files from a directory.

There is also a minor refactoring to remove HandlerFactory from public API of the library. It's replaced by higher level api serve.

@sunng87 sunng87 requested a review from Copilot June 6, 2025 23:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new --dir option for the CLI to automatically register supported files in a specified directory as tables. In addition, it adjusts public re-exports in the library and updates the usage information in the README.

  • Introduces a new method to include directory files by reading file extensions and adding them to corresponding table lists.
  • Adjusts public API usage in the library and updates CLI arguments including new flags for --dir and --host.
  • Updates README documentation to reflect version changes and CLI usage.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
datafusion-postgres/src/lib.rs Updates public re-exports and internal module use for HandlerFactory.
datafusion-postgres-cli/src/main.rs Implements the directory file inclusion logic and updates CLI flags.
README.md Adjusts version, command usage and help text to reflect new options.
Comments suppressed due to low confidence (1)

datafusion-postgres/src/lib.rs:13

  • [nitpick] The public re-export for HandlerFactory has been removed; if this change is intentional to encapsulate implementation details, consider adding a comment or documentation to clarify the rationale.
use handlers::HandlerFactory;

@sunng87 sunng87 merged commit 26af6f5 into master Jun 6, 2025
6 checks passed
@sunng87 sunng87 deleted the feature/cli-serve-directory branch June 6, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant