Skip to content

fix: udf name and pg_is_table_visible #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

fix: udf name and pg_is_table_visible #113

merged 2 commits into from
Jul 13, 2025

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Jul 13, 2025

Fixes residual issues introduced in #112

\dt from psql finally returns no error. I will debug it further to make it return correct results.

@sunng87
Copy link
Member Author

sunng87 commented Jul 13, 2025

datafusion=> select * from pg_catalog.pg_namespace;
 oid  |      nspname       | nspowner | nspacl | options
------+--------------------+----------+--------+---------
   11 | pg_catalog         |       10 |        |
 2200 | public             |       10 |        |
   12 | information_schema |       10 |        |
(3 rows)
datafusion=> select relnamespace, relname from pg_catalog.pg_class;
 relnamespace |      relname
--------------+-------------------
        10000 | pg_type
        10000 | pg_class
        10000 | pg_attribute
        10000 | pg_namespace
        10000 | pg_proc
        10000 | pg_database
        10000 | pg_am
        10000 | pg_range
        10000 | pg_enum
        10010 | player_valuations
        10010 | clubs
        10010 | competitions
        10010 | games
        10010 | transfers
        10010 | game_lineups
        10010 | appearances
        10010 | players
        10010 | game_events
        10010 | club_games
(19 rows)

We just need to make sure the oid mapping is correct and consistent between pg_class and pg_namespace. This requires some state maintained between pg_catalog calls. I will address this later.

@sunng87 sunng87 merged commit e655d53 into master Jul 13, 2025
6 checks passed
@sunng87 sunng87 deleted the fix/pg_catalog_udfs branch July 13, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant