Add plan annotator unit tests#263
Merged
gabotechs merged 1 commit intogabrielmusat/rework-distributed-planning-logicfrom Dec 22, 2025
Merged
Add plan annotator unit tests#263gabotechs merged 1 commit intogabrielmusat/rework-distributed-planning-logicfrom
gabotechs merged 1 commit intogabrielmusat/rework-distributed-planning-logicfrom
Conversation
gabotechs
changed the base branch from
main
to
gabrielmusat/rework-distributed-planning-logic
gabotechs
force-pushed
the
gabrielmusat/add-annotation-tests
branch
from
1825247 to
d9c33eb
Compare
Collaborator
Author
|
I think this PR might actually be better just shipped with #259. It's mean to test it, and its not that big, so IMO it belongs there. |
gabotechs
merged commit 8af7d3b
into
gabrielmusat/rework-distributed-planning-logic
6 checks passed
gabotechs
added a commit
that referenced
this pull request
Dec 24, 2025
* Rework distributed planner * Ignore some failing tests that should not be failing * Improve default task estimator repartition * Update test snapshots * Factor out plan_annotator.rs * Add docs * Respond to PR feedback * Make TaskCountAnnotation public and part of the TaskEstimator API * Add plan annotator tests (#263) * Fix typo * Add docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests to the plan annotator shipped in #259