MOSS Cap1 #1833
Merged
MOSS Cap1 #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekrekr
requested changes
Sep 9, 2024
Ekrekr
requested changes
Sep 10, 2024
Comment on lines
+7
to
+8
| resolved "https://us-npm.pkg.dev/artifact-foundry-prod/ah-3p-staging-npm/@babel/code-frame/-/code-frame-7.8.3.tgz" | ||
| integrity "sha1-M+JZA9dIEYFTThLsCiXxa2/PQZ4=sha512-a9gxpmdXtZEInkCSHUJDLHZVBgb1QS0jhss4cPP93EW7s+uC5bikET2twEF3KV+7rDblJcmNvTR7VJejqd2C2g== sha512-a9gxpmdXtZEInkCSHUJDLHZVBgb1QS0jhss4cPP93EW7s+uC5bikET2twEF3KV+7rDblJcmNvTR7VJejqd2C2g==" |
There was a problem hiding this comment.
What is the process for installing new packages now, or bumping versions? Does yarn install x@1 still work?
There was a problem hiding this comment.
ideally.
bazel run @nodejs//:yarn config set registry https://us-npm.pkg.dev/artifact-foundry-prod/ah-3p-staging-npm/
bazel run @nodejs//:yarn add x@1.
There was a problem hiding this comment.
That's not terrible.
It would be good to document this, right? https://github.com/dataform-co/dataform/blob/main/contributing.md#add-new-npm-dependencies
Ekrekr
reviewed
Sep 11, 2024
Ekrekr
requested changes
Sep 12, 2024
Ekrekr
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order to use GCB for all building and publishing needs, new
cloudbuild-*.yamlfiles are added that will be used by triggers in our GCP project. Moreover,yarn.lockfile has been updated to pull dependencies from google's verified sources.Changes:
yarn.lockto change dependencies location to google npm package manager.cloudbuild.yamlfile and replaced with following new build files.cloudbuild-publish.yaml. This build will get triggered when new code is pushed to main such that theversion.bzlfile has been updated i-e: a new version is ready for release. This will build and published to updated packages to NPM.cloudbuild-test.yaml. This will be trigger when a new PR is created or code is pushed to main such that the version.bzl is not changed. This will run tests.cloudbuild-version.yaml. This will be triggered on 1st of every month. This will update the version number inversion.bzlin a new branch and create a PR to main.scripts/update_version. The previous step uses this script to update the patch version number.