Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook dependency targets #1792

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Fix notebook dependency targets #1792

merged 8 commits into from
Aug 7, 2024

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Jul 30, 2024

Some fixes are:

  • Notebooks can properly be dependency targets of other targets, by hacking from "location" to "dataset" fields.
  • Notebooks, views and incremental tables now correctly convert dependency targets to compiled graph targets.
  • Better type safeness by extracting configs proto target conversion and action configs proto conversion to separate functions.

@Ekrekr Ekrekr requested a review from GJMcGowan July 30, 2024 11:27
@Ekrekr Ekrekr requested a review from chemerisuk August 5, 2024 08:35
chemerisuk
chemerisuk approved these changes Aug 5, 2024
View reviewed changes
Copy link

@chemerisuk chemerisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ekrekr Ekrekr merged commit 1c188e4 into main Aug 7, 2024
4 checks passed
@Ekrekr Ekrekr deleted the fix-notebook-dependency-targets branch August 7, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemerisuk chemerisuk chemerisuk approved these changes

@GJMcGowan GJMcGowan Awaiting requested review from GJMcGowan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ekrekr @chemerisuk