Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Fix mssql, databricks date types #853

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fix mssql, databricks date types #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7865357
"date" should by type Date
dlawin Jan 12, 2024
1fbc008
add date type for databricks
dlawin Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions data_diff/databases/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import attrs

from data_diff.abcs.database_types import (
Date,
Integer,
Float,
Decimal,
Expand Down Expand Up @@ -52,6 +53,7 @@ class Dialect(BaseDialect):
# Timestamps
"TIMESTAMP": Timestamp,
"TIMESTAMP_NTZ": Timestamp,
"DATE": Date,
# Text
"STRING": Text,
"VARCHAR": Text,
Expand Down
3 changes: 2 additions & 1 deletion data_diff/databases/mssql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
)
from data_diff.abcs.database_types import (
JSON,
Date,
NumericType,
Timestamp,
TimestampTZ,
Expand Down Expand Up @@ -46,7 +47,7 @@ class Dialect(BaseDialect):
"datetime": Timestamp,
"datetime2": Timestamp,
"smalldatetime": Timestamp,
"date": Timestamp,
"date": Date,
# Numbers
"float": Float,
"real": Float,
Expand Down