This repository was archived by the owner on May 17, 2024. It is now read-only.
Type annotate some things ("no-brainers") #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
changed the title
nolar
force-pushed
the
type-annotate-everything-2
branch
from
70edcb0 to
e675286
Compare
added 6 commits
January 8, 2024 14:35
nolar
force-pushed
the
type-annotate-everything-2
branch
from
e675286 to
ff76f94
Compare
vvkh
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little by little, let's cleanup the code base. Before doing some big type annotations & clarifications, let's first remove the very obvious chaos where the very obvious annotations are absent and can be added easily as "no-brainers."
The more sophisticated cases where some brain work is needed to infer the supposed types of results & arguments will follow in other PRs — as in the "iterative improvement" approach.
Reviewing individual commits might help — they are split by topic.