Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

closing connection once data diff is executed #785

Merged
merged 52 commits into from
Jan 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
55be7fe
closing connection once data diff is executed
sar009 Nov 28, 2023
78827e8
typo fix
sar009 Nov 29, 2023
d309b98
moving database to with block
sar009 Nov 29, 2023
fe49f40
optimizing _data_diff function
sar009 Nov 29, 2023
933a393
minor
sar009 Nov 29, 2023
dc0147a
minor
sar009 Nov 29, 2023
a916183
bug fix
sar009 Nov 29, 2023
f1a8baa
linter fixes
sar009 Nov 29, 2023
e263027
formating code
sar009 Nov 29, 2023
3dbb6da
update CONTRIBUTING.md and cleanup ansi escape sequences
sar009 Dec 1, 2023
8871d16
Merge branch 'datafold:master' into 784
sar009 Dec 1, 2023
82d2674
Merge branch 'master' into 784
sar009 Dec 6, 2023
ba4182e
Merge branch 'master' into 784
sar009 Dec 21, 2023
8cf6e88
Merge branch 'master' into 784
sar009 Dec 24, 2023
193c2bd
Merge branch 'master' into 784
sar009 Dec 29, 2023
89b2ab7
Merge branch 'master' into 784
sar009 Dec 29, 2023
d78e8e0
Merge branch '784' of github.com:sar009/data-diff into 784
sar009 Dec 30, 2023
4699c66
Merge branch 'master' of github.com:sar009/data-diff into 784
sar009 Dec 30, 2023
3de6c3a
read postgres db config from common.CONN_STRINGS
sar009 Dec 31, 2023
6828c4a
Merge branch 'master' into 784
sar009 Jan 1, 2024
9ac5967
Merge branch 'master' into 784
sungchun12 Jan 2, 2024
1d6c371
defaulting postgres port
sar009 Jan 3, 2024
00aa1be
Merge branch '784' of github.com:sar009/data-diff into 784
sar009 Jan 3, 2024
73c63e0
Merge branch 'master' into 784
sar009 Jan 3, 2024
e9273c4
Merge branch 'master' into 784
sungchun12 Jan 3, 2024
59a9e8b
Merge branch 'master' into 784
sungchun12 Jan 4, 2024
08edfa4
Merge branch 'master' into 784
sar009 Jan 5, 2024
e9a7630
Merge branch 'master' into 784
sar009 Jan 8, 2024
7280344
Merge branch 'master' into 784
sar009 Jan 9, 2024
13bbd5c
Merge branch 'master' into 784
sar009 Jan 10, 2024
3ed4bce
test
sar009 Jan 10, 2024
b2a1542
test for __main__
sar009 Jan 10, 2024
6a86647
adding close db connection test
sar009 Jan 10, 2024
0b9d360
update test case
sar009 Jan 10, 2024
9bf91ce
do not use shared connection
sar009 Jan 10, 2024
9f4ac6e
no connection sharing
sar009 Jan 10, 2024
78d0976
no connection sharing
sar009 Jan 10, 2024
9bd278f
avoid list typing
sar009 Jan 10, 2024
44bddad
Merge branch 'master' into 784
sar009 Jan 11, 2024
4397d7e
Merge branch 'master' into 784
sar009 Jan 12, 2024
a611ccc
Merge branch 'master' into 784
sungchun12 Jan 12, 2024
10c6f36
Update tests/test_main.py
sar009 Jan 14, 2024
2333dfc
Update tests/test_main.py
sar009 Jan 14, 2024
3ec84e0
Apply suggestions from code review
sar009 Jan 14, 2024
ab19d2a
Update tests/test_database.py
sar009 Jan 14, 2024
6d00f42
minor
sar009 Jan 14, 2024
4513be9
minor
sar009 Jan 15, 2024
4c4203d
minor
sar009 Jan 15, 2024
10f6afa
minor
sar009 Jan 15, 2024
09d33a9
Merge branch 'master' into 784
sungchun12 Jan 15, 2024
75713f9
merging 784
sar009 Jan 16, 2024
dba5623
remove redundant variable
sar009 Jan 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/test_main.py
Co-authored-by: Sung Won Chung <sungwonchung3@gmail.com>
  • Loading branch information
sar009 and sungchun12 authored Jan 14, 2024
commit 10c6f3643e24c93bc6ae62555b1d26f9762fe0d6
28 changes: 27 additions & 1 deletion tests/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,33 @@ def test__get_dbs(self) -> None:
assert db1 != db2
assert db1._interactive
assert db2._interactive

def test_database_connection_failure(self) -> None:
"""Test when database connection fails."""
with self.assertRaises(Exception): # Assuming that connect() raises Exception on connection failure
_get_dbs(1, "db1_str", 0, "db2_str", 0, False)

def test_invalid_inputs(self) -> None:
"""Test invalid inputs."""
with self.assertRaises(Exception): # Assuming that connect() raises Exception on failure
_get_dbs(0, "", 0, "", 0, False) # Empty connection strings

def test_database_object(self) -> None:
"""Test returned database objects are valid and not None."""
db1_str: str = CONN_STRINGS[db.PostgreSQL]
db2_str: str = CONN_STRINGS[db.PostgreSQL]
db1, db2 = _get_dbs(1, db1_str, 0, db2_str, 0, False)
self.assertIsNotNone(db1)
self.assertIsNotNone(db2)
self.assertIsInstance(db1, Database)
self.assertIsInstance(db2, Database)

def test_databases_are_different(self) -> None:
"""Test separate connections for different databases."""
db1_str: str = CONN_STRINGS[db.PostgreSQL]
db2_str: str = CONN_STRINGS[db.MySQL]
db1, db2 = _get_dbs(0, db1_str, 1, db2_str, 2, False)
with db1, db2:
self.assertIsNot(db1, db2) # Check that db1 and db2 are not the same object

class TestSetAge(unittest.TestCase):
def setUp(self) -> None:
Expand Down