This repository was archived by the owner on May 17, 2024. It is now read-only.
save and get the api key from the system keyring service #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pik94
added
--dbt
nolar
approved these changes
Apr 11, 2023
dlawin
reviewed
Apr 11, 2023
dlawin
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default an API token to interact with the Datafold cloud is set and stored in an env variable
DATAFOLD_API_KEY. However, it is not convenient is the data-diff is run across multiple terminal. So, it is better to store it somewhere else.Current solution provides an opportunity to store the API key in the system keyring service. When a user sets the api key first time, the key is also stored in the keyring service so if
DATAFOLD_API_KEYis not set in another terminal or process, it is taken from the keyring service.Also would like to emphasize that the value from
DATAFOLD_API_KEYhas a higher priority than a value from the key service, the latter is rewritten in that case.