This repository was archived by the owner on May 17, 2024. It is now read-only.
override --cloud host name #465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlawin
added
enhancement
dlawin
commented
Mar 28, 2023
| @@ -229,7 +233,7 @@ def _cloud_diff(diff_vars: DiffVars) -> None: | |||
| if api_key is None: | |||
| raise ValueError("API key not found, add it as an environment variable called DATAFOLD_API_KEY.") | |||
|
|
|||
| url = "https://app.datafold.com/api/v1/datadiffs" | |||
| url = f"https://{host_name}/api/v1/datadiffs" | |||
There was a problem hiding this comment.
@nolar do you see any reason to override the full endpoint urls? I made an assumption that the host_name is enough
|
Closing as this is addressed in #462 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #461
Adds an additional flag
--cloud-host-name. This flag or the env variableDATAFOLD_API_HOST_NAMEcan be used to override the url for--cloudExample:
--cloud-host-name blah.blah.com-> "blah.blah.com/api/v1/datadiffs" being used. I don't think there's a reason to override the full endpoints