This repository was archived by the owner on May 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 288
Restructure CI output #374
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
31b71fe
initial commit
leoebfolsom e70d5ba
create tabular output focused on PK and column chnages
leoebfolsom cc9ab7b
update poetry.lock
leoebfolsom a1f2a59
update logic in get_stats_string
leoebfolsom 4f58b42
remove hard-coding of primary key column
leoebfolsom 62bc4e4
switch to simpler added/remove language
leoebfolsom 799eef7
change Conflicting Rows to Values Updated per Ari's suggestion
leoebfolsom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this replace the behavior of get_stats_string() instead? Or maybe be an additional method like get_stats_tables_string()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can replace
get_stats_string()
. I don't think there's any drawback at all to fully replacing the existingstring_output
since it is not structured (and therefore depended on by some downstream system)--it's just a string.I will refactor this, and I'm very open to suggestions/recommendations, but I'm going to try to settle on a good design of the output before optimizing the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlawin moved the logic into
get_stats_string
👍 (still could be optimized from here)