This repository was archived by the owner on May 17, 2024. It is now read-only.
This repository was archived by the owner on May 17, 2024. It is now read-only.
Not a soft of manifest.json #540
Closed
Description
Describe the bug
When using data-diff on a manifest.json generated by a recent version of dbt-core, dbt-artifacts-parser can be unable to parse it and the following error is displayed:
ERROR - Not a soft of manifest.json
Before the intended warning:
elif dbt_version >= parse_version(UPPER_DBT_V):
logger.warning(
f"{dbt_version} is a recent version of dbt and may not be fully tested with data-diff!
\nPlease report any issues to https://github.com/datafold/data-diff/issues"
)
Make it clear the version may be unsupported before dbt-artifacts-parser or other parsing code is likely to throw an error:
File "/opt/homebrew/lib/python3.10/site-packages/data_diff/dbt_parser.py", line 57, in __init__
self.manifest_obj = self.get_manifest_obj()
File "/opt/homebrew/lib/python3.10/site-packages/data_diff/dbt_parser.py", line 101, in get_manifest_obj
manifest_obj = self.parse_manifest(manifest=manifest_dict)
File "/opt/homebrew/lib/python3.10/site-packages/dbt_artifacts_parser/parser.py", line 99, in parse_manifest
raise ValueError("Not a soft of manifest.json")
ValueError: Not a soft of manifest.json
So that an issue is more likely to be reported here.